more proper dbstring memory management#506
Closed
fluxide wants to merge 2 commits into
Closed
Conversation
empty_buf function returns a char* now, and the free function in dbarray uses the get_size_ptr function to detect uninitialized void* objects
-identified the problem with heap allocation in dbstrings -empty_buf() now returns 2 bytes, properly mimicking the void* structure of a dbstring.
Author
|
i made one of my commits to my branch 3 months ago. admittedly i dont remember what i changed but if it looks weird feel free to correct anything |
Member
|
Honestly I'm not sure how this change is supposed to work. I'll close it and ask you to create an issue with a test case that triggers the memory problem for you. Problematic changes:
This is simply leaking memory as the raw is overwritten on the next line: Compiler warning: Linker error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on windows, i was getting assertion errors from dbarrayalloc.h months ago when it was struggling with memory management. i have identified that empty_buf() is supposed to return two consequent memory addresses that are supposed to mimick a dbstring structure; however, the existing method seemed to be fragile on windows, so i cleaned it up a little bit. it doesnt seem to show undefined behavior anymore.